adriangb commented on code in PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#discussion_r2024168186
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -498,6 +489,7 @@ impl FileSource for ParquetSource {
reorder_filters: self.reorder_filters(),
enable_page_index: self.enable_page_index(),
enable_bloom_filter: self.bloom_filter_on_read(),
+ enable_stats_pruning: self.table_parquet_options.global.pruning,
Review Comment:
I had to add this for the case where this is disabled (`false`): otherwise
if we push down filters they end up getting used for row group pruning, which
differs from our current behavior.
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -955,7 +939,7 @@ impl TableProvider for ListingTable {
.with_output_ordering(output_ordering)
.with_table_partition_cols(table_partition_cols)
.build(),
- filters.as_ref(),
+ None,
Review Comment:
We kind of need to do this otherwise you end up with duplicate filters for
the case where `ListingTable` said inexact -> a FilterExec gets created -> we
then push down from the filter exec in to the DataSourceExec that already had
the filter -> duplicate filter.
##########
datafusion/core/src/datasource/physical_plan/arrow_file.rs:
##########
@@ -201,7 +201,7 @@ impl ExecutionPlan for ArrowExec {
/// Arrow configuration struct that is given to DataSourceExec
/// Does not hold anything special, since [`FileScanConfig`] is sufficient for
arrow
-#[derive(Clone, Default)]
+#[derive(Clone, Default, Debug)]
Review Comment:
This was just an annoyance during debugging. Can revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
