alamb commented on code in PR #15102:
URL: https://github.com/apache/datafusion/pull/15102#discussion_r1986321168
##########
datafusion/wasmtest/Cargo.toml:
##########
@@ -45,7 +45,7 @@ chrono = { version = "0.4", features = ["wasmbind"] }
# all the `std::fmt` and `std::panicking` infrastructure, so isn't great for
# code size when deploying.
console_error_panic_hook = { version = "0.1.1", optional = true }
-datafusion = { workspace = true }
+datafusion = { workspace = true, features = ["parquet"] }
Review Comment:
Indeed you are right -- I verified I got a compile error without the code
changes in this PR
```shell
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion/datafusion/wasmtest$
wasm-pack build --dev
Compiling datafusion-datasource-csv v46.0.0
(/Users/andrewlamb/Software/datafusion/datafusion/datasource-csv)
error[E0432]: unresolved import
`crate::file_format::coerce_file_schema_to_view_type`
--> datafusion/datasource-parquet/src/opener.rs:23:40
|
23 | coerce_file_schema_to_string_type, coerce_file_schema_to_view_type,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| no
`coerce_file_schema_to_view_type` in `file_format`
| help: a similar name exists in
the module: `coerce_file_schema_to_string_type`
|
note: found an item that was configured out
--> datafusion/datasource-parquet/src/file_format.rs:470:8
|
470 | pub fn coerce_file_schema_to_view_type(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: the item is gated here
--> datafusion/datasource-parquet/src/file_format.rs:469:1
|
469 | #[cfg(not(target_arch = "wasm32"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error[E0425]: cannot find function `coerce_file_schema_to_view_type` in this
scope
--> datafusion/datasource-parquet/src/file_format.rs:726:27
|
519 | / pub fn coerce_file_schema_to_string_type(
520 | | table_schema: &Schema,
521 | | file_schema: &Schema,
522 | | ) -> Option<Schema> {
... |
571 | | }
| |_- similarly named function `coerce_file_schema_to_string_type`
defined here
...
726 | if let Some(merged) =
coerce_file_schema_to_view_type(&table_schema, &file...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a
function with a similar name exists: `coerce_file_schema_to_string_type`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
