XiangpengHao commented on code in PR #15102:
URL: https://github.com/apache/datafusion/pull/15102#discussion_r1986318574
##########
datafusion/wasmtest/Cargo.toml:
##########
@@ -45,7 +45,7 @@ chrono = { version = "0.4", features = ["wasmbind"] }
# all the `std::fmt` and `std::panicking` infrastructure, so isn't great for
# code size when deploying.
console_error_panic_hook = { version = "0.1.1", optional = true }
-datafusion = { workspace = true }
+datafusion = { workspace = true, features = ["parquet"] }
Review Comment:
> Can you help me understand what is different about the parquet viewer that
isn't covered by the existing test?
Here's the secret @alamb . I think the workspace datafusion has all features
disabled. If we enable parquet feature here, we should be able to see compile
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
