XiangpengHao commented on code in PR #15102:
URL: https://github.com/apache/datafusion/pull/15102#discussion_r1986212420


##########
.github/workflows/rust.yml:
##########
@@ -259,6 +259,10 @@ jobs:
         uses: ./.github/actions/setup-builder
         with:
           rust-version: stable
+      - name: Install dependencies
+        run: |
+          apt-get update -qq
+          apt-get install -y -qq clang

Review Comment:
   Without this I got: 
https://github.com/XiangpengHao/datafusion/actions/runs/13744579987/job/38437951143#step:6:144
   
   ```
   warning: zstd-sys@2.0.13+zstd.1.5.6: ToolExecError: Command LC_ALL="C" 
"sccache" "clang" "-O0" "-ffunction-sections" "-fdata-sections" 
"-fno-exceptions" "-g" "-fno-omit-frame-pointer" 
"--target=wasm32-unknown-unknown" "-I" "wasm-shim/" "-I" "zstd/lib/" "-I" 
"zstd/lib/common" "-fvisibility=hidden" "-DZSTD_LIB_DEPRECATED=0" 
"-DXXH_PRIVATE_API=" "-DZSTDLIB_VISIBILITY=" "-DZSTDERRORLIB_VISIBILITY=" "-o" 
"/__w/datafusion/datafusion/target/wasm32-unknown-unknown/debug/build/zstd-sys-789e7626e12bcd14/out/44ff4c55aa9e5133-debug.o"
 "-c" "zstd/lib/common/debug.c" with args clang did not execute successfully 
(status code exit status: 2).cargo:warning=Compiler family detection failed due 
to error: ToolNotFound: Failed to find tool. Is `clang` installed?
   warning: zstd-sys@2.0.13+zstd.1.5.6: Compiler family detection failed due to 
error: ToolNotFound: Failed to find tool. Is `clang` installed?
   warning: zstd-sys@2.0.13+zstd.1.5.6: Compiler family detection failed due to 
error: ToolNotFound: Failed to find tool. Is `clang` installed?
   warning: zstd-sys@2.0.13+zstd.1.5.6: Compiler family detection failed due to 
error: ToolNotFound: Failed to find tool. Is `clang` installed?
   warning: zstd-sys@2.0.13+zstd.1.5.6: sccache: error: failed to execute 
compile
   warning: zstd-sys@2.0.13+zstd.1.5.6: sccache: caused by: cannot find binary 
path
   ```
   
   So I added clang here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to