wForget commented on code in PR #1428:
URL: https://github.com/apache/datafusion-comet/pull/1428#discussion_r1974690157
##########
native/core/src/execution/planner.rs:
##########
@@ -922,13 +956,18 @@ impl PhysicalPlanner {
Ok(DataType::Decimal128(_p2, _s2)),
) => {
let data_type = return_type.map(to_arrow_datatype).unwrap();
+ let func_name = if options.is_integral_div {
Review Comment:
> Thanks for trying, if this is too much trouble, we can file an issue
ticket and can be worked on separately.
Could you please continue review this pr and let us keep changes to
`decimal_div` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
