Re: [PR] feat: Support IntegralDivide function [datafusion-comet]

[via GitHub]

wForget commented on code in PR #1428:
URL: https://github.com/apache/datafusion-comet/pull/1428#discussion_r1973647425


##########
native/core/src/execution/planner.rs:
##########
@@ -922,13 +956,18 @@ impl PhysicalPlanner {
                 Ok(DataType::Decimal128(_p2, _s2)),
             ) => {
                 let data_type = return_type.map(to_arrow_datatype).unwrap();
+                let func_name = if options.is_integral_div {

Review Comment:
   Thanks for your suggestion, it makes sense to me. But I am getting an 
overflow error and I will continue debugging this tomorrow.
   
   
![image](https://github.com/user-attachments/assets/fef0d1b4-c6be-4226-9e48-fc16c6103ab5)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org