kazuyukitanimura commented on code in PR #1428:
URL: https://github.com/apache/datafusion-comet/pull/1428#discussion_r1972119757
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2641,4 +2641,57 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("test integral divide") {
+ Seq(true, false).foreach { dictionaryEnabled =>
+ withTempDir { dir =>
+ val path1 = new Path(dir.toURI.toString, "test1.parquet")
+ val path2 = new Path(dir.toURI.toString, "test2.parquet")
+ makeParquetFileAllTypes(
+ path1,
+ dictionaryEnabled = dictionaryEnabled,
+ 0,
+ 0,
+ randomSize = 10000)
+ makeParquetFileAllTypes(
+ path2,
+ dictionaryEnabled = dictionaryEnabled,
+ 0,
+ 0,
+ randomSize = 10000)
+ withParquetTable(path1.toString, "tbl1") {
+ withParquetTable(path2.toString, "tbl2") {
+ // disable broadcast, as comet on spark 3.3 does not support
broadcast exchange
Review Comment:
I think we can do `assume(isSpark34Plus)` at the very beginning of this test
because we are falling back to spark for the
`decimalBeforeSpark34(left.dataType)` case anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
