iffyio commented on code in PR #1747:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r1972915911
##########
src/ast/dml.rs:
##########
@@ -138,6 +143,30 @@ pub struct CreateTable {
pub engine: Option<TableEngine>,
pub comment: Option<CommentDef>,
pub auto_increment_offset: Option<u32>,
+ pub key_block_size: Option<u32>,
Review Comment:
there's quite a few of these options and its not clear what dialect they're
coming from, I assume there will be more across the various dialects.
I'm thinking to @mvzink's point, it will be good to represent this as a
`Vec`, also think that we can represent this similar to the existing
`with_options: Vec<SqlOption>` on this struct (maybe we can just reuse and
merge this into that field if it makes sense, otherwise it could be a new
field)? essentially that it would be ideal to not have to enumerate and keep in
sync all possible table options across dialects but instead always accept them
as opaque entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
