alamb commented on code in PR #14677:
URL: https://github.com/apache/datafusion/pull/14677#discussion_r1970453979
##########
datafusion/physical-plan/src/display.rs:
##########
@@ -448,13 +492,386 @@ impl ExecutionPlanVisitor for GraphvizVisitor<'_, '_> {
}
}
+struct TreeRenderVisitor<'a, 'b> {
Review Comment:
This looks like it is substantially based on the duckdb implementation:
https://github.com/duckdb/duckdb/pull/1046/files#diff-d1323eac8a19eb719b259e964df5e9248fb17bf3872f4ea0776566dd2a62ab4b
I think we should at least credit where it came from
I also wonder if we should use the latest version:
https://github.com/duckdb/duckdb/blob/main/src/common/tree_renderer/text_tree_renderer.cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
