alamb commented on code in PR #14677:
URL: https://github.com/apache/datafusion/pull/14677#discussion_r1970418321


##########
datafusion/physical-plan/src/memory.rs:
##########
@@ -192,6 +192,7 @@ impl DisplayAs for LazyMemoryExec {
                         .join(", ")
                 )
             }
+            _ => todo!(),

Review Comment:
   I think following the other APIs (aka return the same as Indent) would be 
better still



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to