alamb commented on code in PR #14677:
URL: https://github.com/apache/datafusion/pull/14677#discussion_r1970408575
##########
datafusion/datasource/src/source.rs:
##########
@@ -43,6 +44,7 @@ pub trait DataSource: Send + Sync {
) -> datafusion_common::Result<SendableRecordBatchStream>;
fn as_any(&self) -> &dyn Any;
fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> fmt::Result;
+ fn collect_info(&self) -> HashMap<String, String>;
Review Comment:
I agree with this -- it would be much better to avoid a new interface and
instead update the existing `fmt_as` API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
