andygrove commented on code in PR #1376: URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1954807881
########## common/src/main/scala/org/apache/comet/CometConf.scala: ########## @@ -608,6 +608,14 @@ object CometConf extends ShimCometConf { .booleanConf .createWithDefault(false) + val COMET_SCAN_ALLOW_INCOMPATIBLE: ConfigEntry[Boolean] = + conf("spark.comet.scan.allowIncompatible") + .doc( + "Comet is not currently fully compatible with Spark for all datatypes. " + + s"Set this config to true to allow them anyway. $COMPAT_GUIDE.") Review Comment: We link to the Compatibility Guide here but there is no new information in that guide about handling for byte/short, so would be good to add that. This could be done in a follow on PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org