andygrove commented on code in PR #1376:
URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1951175661
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -429,65 +429,131 @@ abstract class CometTestBase
makeParquetFileAllTypes(path, dictionaryEnabled, 0, n)
}
- def makeParquetFileAllTypes(
- path: Path,
- dictionaryEnabled: Boolean,
- begin: Int,
- end: Int,
- pageSize: Int = 128,
- randomSize: Int = 0): Unit = {
- val schemaStr =
+ def getAllTypesParquetSchema: String = {
Review Comment:
If we are renaming this method, I wonder if we should remove the `AllTypes`
part since it does not generate all types. Perhaps
`getPrimitiveTypesParquetSchema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
