parthchandra commented on code in PR #1376:
URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1946997661
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -125,6 +125,26 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("uint data type support") {
+ Seq(true, false).foreach { dictionaryEnabled =>
+ Seq(Byte.MaxValue, Short.MaxValue).foreach { valueRanges =>
+ {
+ withTempDir { dir =>
+ val path = new Path(dir.toURI.toString, "testuint.parquet")
+ makeParquetFileAllTypes(path, dictionaryEnabled =
dictionaryEnabled, valueRanges + 1)
+ withParquetTable(path.toString, "tbl") {
+ if
(CometSparkSessionExtensions.isComplexTypeReaderEnabled(conf)) {
+ checkSparkAnswer("select _9, _10 FROM tbl order by _11")
Review Comment:
Just 8 and 16 bit.
I started with the fallback to spark _and_ a compat override. The reason I
reverted it is that I couldn't see a way to get to compatibility with spark
even after/if https://github.com/apache/arrow-rs/issues/7040 is addressed.
Let me do as you suggest. Marking this as draft in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
