alamb commented on PR #14567: URL: https://github.com/apache/datafusion/pull/14567#issuecomment-2656570666
> @alamb Thanks for such a detailed example and explanation. I think this transformation is correct in this case. > > according to this [doc](https://docs.rs/datafusion/latest/datafusion/physical_optimizer/pruning/struct.PruningPredicate.html#contains-analysis-and-minmax-rewrite), returning True will **KEEP** the container. > > > When the min/max values are actually substituted in to this expression and evaluated, the result means > > true: there MAY be rows that pass the predicate, KEEPS the container yes, I apologize, you are correct 🤦 I am thinking about other potential counter examples. I am also trying to come up with some example where this transformation would not prune a container that a transoformation like the one from @findepi would do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
