shehabgamin commented on issue #12635: URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2655822219
@findepi Thank you for thoroughly exploring this topic and creating such a detailed design document! @linhr and I have reviewed it and have some initial thoughts: This approach is promising! The design would significantly reduce boilerplate code when authoring row-wise functions. However, implementing it through `proc_macro` could introduce significant complexity into the codebase. We'd like to better understand how this design would help with function signature customization. Could you clarify if there are specific goals or non-goals around this aspect? For example, we're wondering about scenarios where downstream crates might need to override the default signature to express constraints or define allowed coercible behavior. Additionally, it would be helpful to understand how the design handles cases where we might want to customize return types based on specific requirements (e.g., choosing between `Int32` and `Int64` outputs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
