comphead commented on issue #12635: URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2654675641
Thanks @findepi and everyone, this work is epic, literally. in DataFusion it was always needed to unify the builtin functions as they implemented by different developers in different times. Please also consider that functions can be declared in separate or even external crates and be plugged dynamically like now we discussing https://github.com/apache/datafusion/issues/5600 Thanks for the google doc, would you mind attach here the final result how procedural macros are unwrapped into the function code supporting all the attributes like `#vectorized` `#arg(n)`, `#constant`, etc. Another thing coming to my mind is to optimize builtin function if we know that the function parameter set by user is actually a literal which provides further optimizations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
