Omega359 commented on issue #12635: URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2650993466
I love the work that you've put into this! You use the regexp_like as an example of what could be handled by if you look at that function it actually doesn't operate on individual values but delegates the whole arrays off to arrow-string. My primary concern with this is not the direction at all - I love it. I am concerned primarily how to handle functions mixing string arrays and scalars. The whole casting logic for the various string types can get quite laboured and until Rust has Enum values as types I don't see a way around it unless we just force everything to a common type (GenericStringArray<T> ?) which would remove the benefit of using something like StringViewArray. I'm going to review the doc again later today and think about it a bit more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
