jayzhan211 commented on PR #14268: URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2629240637
> ### Topic 1 > > @findepi I had thought about using Signature:: User-defined everywhere before but was rejected for some reason. As the discussion here, I think we need this to minimize the impact of any changes that is required for datafusion builtun function but not for other projects. Any thoughts to add in? > > @alamb @jayzhan211 Are we waiting on @findepi to chime in, or should I just go ahead with this approach? > > ### Topic 2 > > It does seem to me that we keep churning / thrashing on coercion (and introducing regressions like the one this PR fixes along with https://github.com/apache/datafusion/issues/14154 and https://github.com/apache/datafusion/issues/14383 > > > > To me this is a sign we need more work as @jayzhan211 says and I am sure we would appreciate help figuring out what to do / making the code better > > I am happy to help out here! I think that we all want the same thing, but what's going on is that it's hard for all of us to be fully contextualized with everything so we end up going in circles. > > @alamb @jayzhan211 Let's bring the conversation back here https://github.com/apache/datafusion/issues/14296 and try to get this topic resolved for DataFusion 46. I would also like to note that I'm always happy to hop on a call or do some sort of live messaging if that's ever desired. > If the approach looks good to you too, we can go ahead! We already have user defined coercion for functions, #14296 is for binary op or case expression and so on. If we agree to use User-defined coercion for functions everywhere, modify coerce types are the easier fix that can go into release quicker. Another better design is to redesign a good method for the function trait, I will also think about the design too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
