jayzhan211 commented on PR #14268: URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2628913239
> > So what is the actual regressions to be resolved? I don't remember signature coericible is consistent with the docs before so it is not a regression to be fixed now. If supporting binary for string is something used to work, then we can add such coercion logic to signature:: string > > @jayzhan211 The regressions resolved are all the UDFs listed in the PR description. Every test added to this PR passed on DataFusion `42`, and then every test that tested coercion behavior started failing on DataFusion `43`. > > Signature coericible not being consistent with the documentation is a big problem, this PR fixes that. > > > Is there any way we can fix the regression bug with some sort of smaller patch and then make the changes to coerceable behavior as a follow on PR? > > @alamb The changes to the coercible behavior are already very small and are outlined below. > ### Changes To Coercible Behavior > > **1. We go from this:** > https://github.com/apache/datafusion/blob/9d1bfc1bfb4b6fc59c36a391b21d5b4bb7191804/datafusion/expr/src/type_coercion/functions.rs#L585-L604 > **To this:** > https://github.com/apache/datafusion/blob/d0f3f9adec75bb80ef05dc6aca33f2e0621c9c3b/datafusion/expr/src/type_coercion/functions.rs#L542-L545 > > **2. Before this line:** > https://github.com/apache/datafusion/blob/9d1bfc1bfb4b6fc59c36a391b21d5b4bb7191804/datafusion/expr/src/type_coercion/functions.rs#L640 > **We add this:** > https://github.com/apache/datafusion/blob/d0f3f9adec75bb80ef05dc6aca33f2e0621c9c3b/datafusion/expr/src/type_coercion/functions.rs#L581-L597 > > That's it. > > Just now i've implemented `TypeSignatureClass::Integer` and updated `repeat` to use that. Beyond this, I'm really not sure how to move forward here. The documentation is wrong but we should fix the description in this case, because the Coercible is introduced not because of we need a very flexible coercion logic but the logic like it is now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
