jayzhan211 commented on PR #14268: URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2628939208
> @shehabgamin can we try to use Singatur::User-defined coerce types for those functions, the change is relatively trivial and the impact is smaller than the current one @findepi I had thought about using Signature:: User-defined everywhere before but was rejected for some reason. As the discussion here, I think we need this to minimize the impact of any changes that is required for datafusion builtun function but not for other projects. Any thoughts to add in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org