comphead commented on code in PR #1349:
URL: https://github.com/apache/datafusion-comet/pull/1349#discussion_r1934192543
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2371,83 +2384,17 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
withInfo(expr, "unsupported arguments for GetArrayStructFields",
child)
None
}
- case expr: ArrayRemove => CometArrayRemove.convert(expr, inputs, binding)
- case expr if expr.prettyName == "array_contains" =>
- createBinaryExpr(
- expr,
- expr.children(0),
- expr.children(1),
- inputs,
- binding,
- (builder, binaryExpr) => builder.setArrayContains(binaryExpr))
- case _ if expr.prettyName == "array_append" =>
- createBinaryExpr(
- expr,
- expr.children(0),
- expr.children(1),
- inputs,
- binding,
- (builder, binaryExpr) => builder.setArrayAppend(binaryExpr))
- case _ if expr.prettyName == "array_intersect" =>
- createBinaryExpr(
- expr,
- expr.children(0),
- expr.children(1),
- inputs,
- binding,
- (builder, binaryExpr) => builder.setArrayIntersect(binaryExpr))
- case ArrayJoin(arrayExpr, delimiterExpr, nullReplacementExpr) =>
- val arrayExprProto = exprToProto(arrayExpr, inputs, binding)
- val delimiterExprProto = exprToProto(delimiterExpr, inputs, binding)
-
- if (arrayExprProto.isDefined && delimiterExprProto.isDefined) {
- val arrayJoinBuilder = nullReplacementExpr match {
- case Some(nrExpr) =>
- val nullReplacementExprProto = exprToProto(nrExpr, inputs,
binding)
- ExprOuterClass.ArrayJoin
- .newBuilder()
- .setArrayExpr(arrayExprProto.get)
- .setDelimiterExpr(delimiterExprProto.get)
- .setNullReplacementExpr(nullReplacementExprProto.get)
- case None =>
- ExprOuterClass.ArrayJoin
- .newBuilder()
- .setArrayExpr(arrayExprProto.get)
- .setDelimiterExpr(delimiterExprProto.get)
- }
- Some(
- ExprOuterClass.Expr
- .newBuilder()
- .setArrayJoin(arrayJoinBuilder)
- .build())
- } else {
- val exprs: List[Expression] = nullReplacementExpr match {
- case Some(nrExpr) => List(arrayExpr, delimiterExpr, nrExpr)
- case None => List(arrayExpr, delimiterExpr)
- }
- withInfo(expr, "unsupported arguments for ArrayJoin", exprs: _*)
- None
- }
- case ArraysOverlap(leftArrayExpr, rightArrayExpr) =>
- if (CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.get()) {
- createBinaryExpr(
- expr,
- leftArrayExpr,
- rightArrayExpr,
- inputs,
- binding,
- (builder, binaryExpr) => builder.setArraysOverlap(binaryExpr))
- } else {
- withInfo(
- expr,
- s"$expr is not supported yet. To enable all incompatible casts,
set " +
- s"${CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key}=true")
- None
- }
+ case _: ArrayRemove => convert(CometArrayRemove)
+ case _: ArrayContains => convert(CometArrayContains)
+ case _ if expr.prettyName == "array_append" => convert(CometArrayAppend)
Review Comment:
```suggestion
// Function introduced in 3.4.0. Refer by name to provide
compatibility with older Spark builds
case _ if expr.prettyName == "array_append" =>
convert(CometArrayAppend)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
