comphead commented on code in PR #1349:
URL: https://github.com/apache/datafusion-comet/pull/1349#discussion_r1934186350
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -929,6 +929,19 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
binding: Boolean): Option[Expr] = {
SQLConf.get
+ def convert(handler: CometExpressionSerde): Option[Expr] = {
+ handler match {
+ case _: IncompatExpr if !CometConf.COMET_EXPR_ALLOW_INCOMPATIBLE.get()
=>
+ withInfo(
+ expr,
+ s"$expr is not fully compatible with Spark. To enable it anyway,
set " +
Review Comment:
```suggestion
s"$expr is not fully compatible with Spark, see details in
Compatibility Guide. To enable it anyway, set " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
