andygrove commented on code in PR #1349:
URL: https://github.com/apache/datafusion-comet/pull/1349#discussion_r1933951486
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -3490,3 +3437,6 @@ trait CometExpressionSerde {
inputs: Seq[Attribute],
binding: Boolean): Option[ExprOuterClass.Expr]
}
+
+/** Marker trait for an expression that is not guaranteed to be 100%
compatible with Spark */
+trait IncompatExpr {}
Review Comment:
Later, we could add a method to this trait to provide the reason why an
expression is incompatible and this could be used to generate documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
