xudong963 commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1933897333
##########
datafusion/physical-optimizer/src/limit_pushdown.rs:
##########
@@ -248,7 +247,15 @@ pub fn pushdown_limit_helper(
}
} else {
// Add fetch or a `LimitExec`:
- global_state.satisfied = true;
+ // If the plan's children have limit and the child's limit <
parent's limit, we shouldn't change the global state to true,
+ // because the children limit will be overridden if the global
state is changed.
+ if pushdown_plan
+ .children()
+ .iter()
+ .any(|&child| extract_limit(child).is_some())
+ {
+ global_state.satisfied = false;
+ }
Review Comment:
I think the logic is strange, if comes to the else branch(248 lines), it
means `global_state.satisfied == false;`, then here(257 lines) sets
`global_state.satisfied = false;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
