zhuqi-lucas commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1933513054
##########
datafusion/physical-optimizer/src/limit_pushdown.rs:
##########
@@ -247,7 +246,15 @@ pub fn pushdown_limit_helper(
}
} else {
// Add fetch or a `LimitExec`:
- global_state.satisfied = true;
+ // If the plan's children have limit, we shouldn't change the
global state to true,
Review Comment:
Good question @xudong963 , added the slt testing for children's limit is >=
the globe limit, the limit should also support push down consistent with
current behaviour, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
