alamb commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1931250259


##########
datafusion/sqllogictest/test_files/joins.slt:
##########
@@ -4247,8 +4247,10 @@ logical_plan
 physical_plan
 01)CoalesceBatchesExec: target_batch_size=3, fetch=2
 02)--HashJoinExec: mode=CollectLeft, join_type=Full, on=[(c1@0, c1@0)]
-03)----MemoryExec: partitions=1, partition_sizes=[1]
-04)----MemoryExec: partitions=1, partition_sizes=[1]
+03)----GlobalLimitExec: skip=0, fetch=2

Review Comment:
   I think this line looks suspicious. 
   
   ```
               Full => (Some(limit), Some(limit)),
   
   ```
   
    I will work on trying to file a bug tomorrow. BTW I don't think this is 
introduced in your PR
   
   I have also marked this PR as must be part of the 45 release
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to