graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1928957606
##########
tests/sqlparser_bigquery.rs:
##########
@@ -39,7 +39,7 @@ fn parse_literal_string() {
r#"'''triple-single'unescaped''', "#,
r#""double\"escaped", "#,
r#""""triple-double\"escaped""", "#,
- r#""""triple-double"unescaped""""#,
+ r#""""triple-double"un'escaped""""#,
Review Comment:
Yes, because currently there is no test for a single quote inside a triple
quoted string. Thought it's a good idea to test this formatting behavior.
(Considering the other bug I found in the formatting.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
