iffyio commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1935163485
##########
src/ast/value.rs:
##########
@@ -97,6 +97,37 @@ pub enum Value {
Placeholder(String),
}
+impl Value {
+ /// Get the string value of a `Value` wrapping a string.
+ /// This includes all quotation styles
+ ///
`{Single,Double,TripleSingle,TripleDouble}{QuotedString,RawString,ByteString}`
+ /// as well as `EscapedStringLiteral`, `UnicodeStringLiteral`,
`NationalStringLiteral`,
+ /// `HexStringLiteral`, `DollarQuotedString`.
+ /// This will panic if called on a non-string variant like
`Value::Number`` or `Value::Null`.
+ pub fn as_str(self) -> String {
Review Comment:
```suggestion
pub fn into_string(self) -> Option<String> {
```
The `into` prefix since this is consuming self and returning a new value (vs
reference).
Then we want this to return None vs panic if the underlying literal isn't a
string
##########
src/ast/value.rs:
##########
@@ -97,6 +97,37 @@ pub enum Value {
Placeholder(String),
}
+impl Value {
+ /// Get the string value of a `Value` wrapping a string.
+ /// This includes all quotation styles
+ ///
`{Single,Double,TripleSingle,TripleDouble}{QuotedString,RawString,ByteString}`
+ /// as well as `EscapedStringLiteral`, `UnicodeStringLiteral`,
`NationalStringLiteral`,
+ /// `HexStringLiteral`, `DollarQuotedString`.
Review Comment:
hmm seems it might not be worth enumerating the types after all since we
have a lot of them. We could say something like
```text
/// If the underlying literal is a string, regardless of quote style,
returns the associated string value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
