graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1928955736
##########
tests/sqlparser_bigquery.rs:
##########
@@ -48,34 +48,34 @@ fn parse_literal_string() {
let select = dialect.verified_only_select(sql);
assert_eq!(10, select.projection.len());
assert_eq!(
- &Expr::Value(Value::SingleQuotedString("single".to_string())),
+ &Expr::Value(Value::SingleQuotedString("single".into())),
Review Comment:
Yeah unrelated, was just tidying up to make the usage all consistent in the
same file and not jump back and forth between into() and to_string(). Can
revert this to make the PR simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
