andygrove commented on PR #1021:
URL: 
https://github.com/apache/datafusion-comet/pull/1021#issuecomment-2567889786

   I had to remove the following code from `CometSparkSessionExtensions` to 
test with off-heap disabled. We can remove this in a follow up PR as well.
   
   ```scala
         if (!isOffHeapEnabled(conf) && !isTesting) {
           logWarning("Comet native exec disabled because 
spark.memory.offHeap.enabled=false")
           withInfo(plan, "Comet native exec disabled because 
spark.memory.offHeap.enabled=false")
           return plan
         }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to