viirya commented on code in PR #1021:
URL: https://github.com/apache/datafusion-comet/pull/1021#discussion_r1901185353
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -467,6 +467,15 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
+ val COMET_EXEC_MEMORY_POOL_TYPE: ConfigEntry[String] =
conf("spark.comet.exec.memoryPool")
+ .doc(
+ "The type of memory pool to be used for Comet native execution. " +
+ "Available memory pool types are 'greedy', 'fair_spill',
'greedy_task_shared', " +
+ "'fair_spill_task_shared', 'greedy_global' and 'fair_spill_global', By
default, " +
+ "this config is 'greedy_task_shared'.")
Review Comment:
Yea, I am not sure if all users can understand the difference between these
pool configs. It is better we can add more description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
