Kontinuation commented on code in PR #1021:
URL: https://github.com/apache/datafusion-comet/pull/1021#discussion_r1901394431
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -84,6 +87,30 @@ class CometExecIterator(
private var currentBatch: ColumnarBatch = null
private var closed: Boolean = false
+ private def getMemoryLimitPerTask(conf: SparkConf): Long = {
+ val numCores = numDriverOrExecutorCores(conf).toFloat
+ val maxMemory = CometSparkSessionExtensions.getCometMemoryOverhead(conf)
Review Comment:
I thought that overhead memory is the amount of native memory reserved for
comet to use. The actual memory usage will be doubled if we reserve the same
amount of executor memory for comet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
