joseph-isaacs commented on code in PR #13491:
URL: https://github.com/apache/datafusion/pull/13491#discussion_r1856333606


##########
datafusion/expr/src/udf.rs:
##########
@@ -330,7 +328,7 @@ where
 
 pub struct ScalarFunctionArgs<'a> {
     // The evaluated arguments to the function
-    pub args: &'a [ColumnarValue],
+    pub args: Vec<ColumnarValue>,

Review Comment:
   I am happy to remove this, but it will unwind a lot of tests changes needed 
to allow this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to