joseph-isaacs commented on code in PR #13491:
URL: https://github.com/apache/datafusion/pull/13491#discussion_r1853899040
##########
datafusion/functions/src/utils.rs:
##########
@@ -170,7 +171,8 @@ pub mod test {
}
else {
// invoke is expected error - cannot use .expect_err()
due to Debug not being implemented
- match
func.invoke_with_args(datafusion_expr::ScalarFunctionArgs{args: $ARGS,
number_rows: cardinality, return_type: &return_type.unwrap()}) {
+ #[allow(deprecated)]
Review Comment:
A lot of tests use this macro and pass in &[], so it quite a big change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
