alamb commented on code in PR #13491:
URL: https://github.com/apache/datafusion/pull/13491#discussion_r1855178653
##########
datafusion/functions/src/datetime/date_bin.rs:
##########
@@ -544,7 +548,7 @@ mod tests {
ColumnarValue::Array(timestamps),
ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
],
- batch_size,
+ 1,
Review Comment:
This seems incorrect -- the batch size was 6 values, not 1
##########
datafusion/expr/src/udf.rs:
##########
@@ -330,7 +328,7 @@ where
pub struct ScalarFunctionArgs<'a> {
// The evaluated arguments to the function
- pub args: &'a [ColumnarValue],
+ pub args: Vec<ColumnarValue>,
Review Comment:
This is the change proposed in ✅
- https://github.com/apache/datafusion/issues/13516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
