goldmedal commented on code in PR #12896:
URL: https://github.com/apache/datafusion/pull/12896#discussion_r1802242261
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -667,12 +667,95 @@ where
}
#[test]
-fn test_table_scan_pushdown() -> Result<()> {
+fn test_table_scan_alias() -> Result<()> {
let schema = Schema::new(vec![
Field::new("id", DataType::Utf8, false),
Field::new("age", DataType::Utf8, false),
]);
+ let plan = table_scan(Some("t1"), &schema, None)?
+ .project(vec![col("id")])?
+ .alias("a")?
+ .build()?;
+ let sql = plan_to_sql(&plan)?;
+ assert_eq!(
+ format!("{}", sql),
+ "SELECT * FROM (SELECT t1.id FROM t1) AS a"
+ );
+
+ let plan = table_scan(Some("t1"), &schema, None)?
+ .project(vec![col("id")])?
+ .alias("a")?
+ .build()?;
+
+ let sql = plan_to_sql(&plan)?;
+ assert_eq!(
+ format!("{}", sql),
+ "SELECT * FROM (SELECT t1.id FROM t1) AS a"
+ );
+
+ let plan = table_scan(Some("t1"), &schema, None)?
+ .filter(col("id").gt(lit(5)))?
+ .project(vec![col("id")])?
+ .alias("a")?
+ .build()?;
+ println!("{}", plan.display_indent());
+ let sql = plan_to_sql(&plan)?;
+ assert_eq!(
+ format!("{}", sql),
+ "SELECT * FROM (SELECT t1.id FROM t1 WHERE (t1.id > 5)) AS a"
+ );
+
+ let table_scan_with_two_filter = table_scan_with_filters(
+ Some("t1"),
+ &schema,
+ None,
+ vec![col("id").gt(lit(1)), col("age").lt(lit(2))],
+ )?
+ .project(vec![col("id")])?
+ .alias("a")?
+ .build()?;
Review Comment:
It's formatted by the cargo formatter. I think we can't control it 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
