goldmedal commented on code in PR #12896:
URL: https://github.com/apache/datafusion/pull/12896#discussion_r1801666802
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -697,7 +739,7 @@ fn test_table_scan_pushdown() -> Result<()> {
plan_to_sql(&table_scan_with_projection_alias)?;
assert_eq!(
format!("{}", table_scan_with_projection_alias),
- "SELECT ta.id, ta.age FROM t1 AS ta"
+ "SELECT * FROM (SELECT ta.id, ta.age FROM t1 AS ta) AS ta"
Review Comment:
Thanks @findepi. Sorry for replying so late 🙇
You're right. I shouldn't break the result of the table scan with any
pushdown. I stopped projecting a wildcard if the `SubqueryAlias`'s child is a
pushdown table scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
