notfilippo commented on PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#issuecomment-2298396570
I'm happy to report that I've got most sqllogictests to run successfully
(albeit there is still the issue pointed out by @alamb, which i plan to address
after I've got all tests passing). The only issues I'm having are the following:
### Aggregates using ScalarValues as state
Aggregates use ScalarValue to represent state and evaluate to a result.
Should I look into restricting their return type to the subset of types which
can be represented by ScalarValues?
```
External error: query failed: DataFusion error: Arrow error: Invalid
argument error: column types must match schema types, expected LargeUtf8 but
found Utf8 at column index 3
[SQL] SELECT
min(utf8),
max(utf8),
count(utf8),
min(largeutf8),
max(largeutf8),
count(largeutf8)
FROM t
at test_files/aggregate.slt:4104
```
### Weird error I don't quite understand
Removing this query doesn't yield any other error in the slt file. I don't
have any other clue and I'm not sure where to start 🤷 .
```
External error: query result mismatch:
[SQL] SELECT
count,
LAG(timestamp, 1) OVER (ORDER BY timestamp),
arrow_typeof(LAG(timestamp, 1) OVER (ORDER BY timestamp))
FROM timestamp_with_tz
LIMIT 10;
[Diff] (-expected|+actual)
0 NULL Timestamp(Millisecond, Some("UTC"))
0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
- 4 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
- 0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
+ 12 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
+ 2 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
14 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
- 0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
- 0 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
+ 5 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
+ 1 2014-08-27T14:00:00Z Timestamp(Millisecond, Some("UTC"))
at test_files/parquet.slt:255
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
