jayzhan211 commented on PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#issuecomment-2294848052
Yeah, I think Datum is actually what we need. After casting the array, we
don't need to convert it back to ScalarValue, it has additional conversion cost
and the physical type information is lost too. Ideally we could replace
ColumnarValue with Datum, but it seems the change is quite large.
We could try replacing ScalarValue with Scalar.
```rust
enum ColumnarValue {
Array(Arc<dyn Array>),
Scalar(arrow_array::Scalar)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
