jayzhan211 commented on PR #11978: URL: https://github.com/apache/datafusion/pull/11978#issuecomment-2308124082
> > UIpd: It seems there is only one place that calls Accumulator::evaluate and transform it to ArrayRef, I think we can just change the return value to ArrayRef for Accumulator::evaluate > > It seems like this solution is not that easy as the state needs to also be accounted for, but it's definitely a good start! Hmm, I don't think there is any issue with `state`. You don't need to change `state`, only `evaluate` is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
