jayzhan211 commented on PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#issuecomment-2294518747
> I wonder if we could do some sort of hybrid approach where `ScalarValue`
still retains a DataType, type, but it isn't encoded in the variant
>
> like
>
> ```rust
> enum ScalarValue {
> ...
> /// A logical string value, with the specified data type
> ScalarValue::Utf8(String, DataType) ,
> }
> ```
>
> That way you would still have the `DataType` for each `ScalarValue` 🤔
This should be the last resort if we don't have any other way to figure the
actual target type to cast to. Otherwise, IMO this is just a code
simplification (Still a nice step forward) but not the goal of decoupling types
#11513 , since we still hide the physical type inside `ScalarValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
