notfilippo commented on code in PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#discussion_r1720046566
##########
datafusion/sqllogictest/test_files/string_view.slt:
##########
@@ -270,37 +270,37 @@ explain SELECT column1_utf8 from test where 'Andrew' =
column1_utf8view;
----
logical_plan
01)Projection: test.column1_utf8
-02)--Filter: test.column1_utf8view = Utf8View("Andrew")
+02)--Filter: CAST(Utf8("Andrew") AS Utf8View) = test.column1_utf8view
03)----TableScan: test projection=[column1_utf8, column1_utf8view]
query TT
explain SELECT column1_utf8 from test where column1_utf8 =
arrow_cast('Andrew', 'Utf8View');
----
logical_plan
-01)Filter: test.column1_utf8 = Utf8("Andrew")
+01)Filter: CAST(test.column1_utf8 AS Utf8View) = CAST(Utf8("Andrew") AS
Utf8View)
Review Comment:
Totally agree! I'm aiming at restoring most of the sqllogictests (and this
behaviour should be easy to catch) to their original expected results so
consider the edits just as a way to make the test progress so it can surface
more weird behaviours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
