kosiew commented on code in PR #23185:
URL: https://github.com/apache/datafusion/pull/23185#discussion_r3517929611
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -642,61 +642,71 @@ pub struct JoinData {
pub join_on: JoinOn,
}
-pub fn try_pushdown_through_join(
+pub(crate) fn try_pushdown_through_join(
Review Comment:
I think we still need to preserve the existing public
`try_pushdown_through_join` API here. `cargo-semver-checks` is flagging this as
`function_missing`, and downstream users that import
`datafusion_physical_plan::projection::try_pushdown_through_join` would break
without a major version bump.
Could we keep the old public function path and signature as a compatibility
wrapper, then move the new `ColumnIndex` aware implementation into a
crate-private helper for the join call sites? For example, `HashJoinExec` and
`NestedLoopJoinExec` could call a renamed `pub(crate)` helper that accepts
`&[ColumnIndex]`, while the existing public API remains available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
