Phoenix500526 commented on code in PR #23185:
URL: https://github.com/apache/datafusion/pull/23185#discussion_r3562980121
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -706,6 +706,80 @@ pub fn try_pushdown_through_join(
}))
}
+pub(crate) fn try_pushdown_through_join_with_column_indices(
Review Comment:
`try_pushdown_through_join` no longer has any in-tree callers. I kept it
only because it is public API and removing it was flagged by
cargo-semver-checks.
Would you prefer to remove it and treat this as an API change, or keep it as
a thin compatibility wrapper that delegates to the ColumnIndex-aware
implementation? The wrapper would eliminate the duplicated logic noted below
while preserving compatibility.
I can also migrate `SymmetricHashJoinExec`, since it already stores the
required column_indices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
