alamb commented on code in PR #23185:
URL: https://github.com/apache/datafusion/pull/23185#discussion_r3562652467
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1557,23 +1557,21 @@ impl ExecutionPlan for HashJoinExec {
return Ok(None);
}
- // TODO: split by `col`/`JoinSide` instead so mark joins can also push
down to children.
let schema = self.schema();
- if !matches!(self.join_type(), JoinType::LeftMark |
JoinType::RightMark)
- && let Some(JoinData {
- projected_left_child,
- projected_right_child,
- join_filter,
- join_on,
- }) = try_pushdown_through_join(
Review Comment:
Do we still need try_pushdown_through_join after this PR? Perhaps we should
remove it (or migrate other sites over that still use it)?
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -706,6 +706,80 @@ pub fn try_pushdown_through_join(
}))
}
+pub(crate) fn try_pushdown_through_join_with_column_indices(
Review Comment:
this looks pretty similar to `try_pushdown_through_join` above it -- maybe
it could be consolidated so we dn't have two copies 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
