notashes commented on code in PR #20182:
URL: https://github.com/apache/datafusion/pull/20182#discussion_r2779128558
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -205,5 +269,79 @@ where
Arc::new(array)
}
+fn boolean_array(array_len: usize) -> ArrayRef {
+ let mut rng = make_rng();
+ Arc::new(
+ (0..array_len)
+ .map(|_| Some(rng.random::<bool>()))
+ .collect::<arrow::array::BooleanArray>(),
+ )
+}
+
+fn string_array(array_len: usize) -> ArrayRef {
Review Comment:
done! don't think a different one offers any benefit! both seem to give me
close to 10% speed up locally (with the struct_array optimization)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
