notashes commented on code in PR #20182:
URL: https://github.com/apache/datafusion/pull/20182#discussion_r2778645410
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -47,50 +51,75 @@ fn criterion_benchmark(c: &mut Criterion) {
BenchData {
name: "int64",
array: primitive_array::<Int64Type>(BATCH_SIZE),
+ supports_nulls: true,
},
BenchData {
name: "utf8",
array: pool.string_array::<i32>(BATCH_SIZE),
+ supports_nulls: true,
},
BenchData {
name: "large_utf8",
array: pool.string_array::<i64>(BATCH_SIZE),
+ supports_nulls: true,
},
BenchData {
name: "utf8_view",
array: pool.string_view_array(BATCH_SIZE),
+ supports_nulls: true,
},
BenchData {
name: "utf8_view (small)",
array: small_pool.string_view_array(BATCH_SIZE),
+ supports_nulls: true,
},
BenchData {
name: "dictionary_utf8_int32",
array: pool.dictionary_array::<Int32Type>(BATCH_SIZE),
+ supports_nulls: true,
+ },
+ BenchData {
+ name: "struct_array",
+ array: create_struct_array(BATCH_SIZE),
+ supports_nulls: true,
+ },
+ BenchData {
+ name: "run_array_int32",
+ array: create_run_array::<Int32Type>(BATCH_SIZE),
+ supports_nulls: true,
},
];
- for BenchData { name, array } in cases {
- // with_hash has different code paths for single vs multiple arrays
and nulls vs no nulls
- let nullable_array = add_nulls(&array);
+ for BenchData {
+ name,
+ array,
+ supports_nulls,
+ } in cases
+ {
c.bench_function(&format!("{name}: single, no nulls"), |b| {
do_hash_test(b, std::slice::from_ref(&array));
});
- c.bench_function(&format!("{name}: single, nulls"), |b| {
- do_hash_test(b, std::slice::from_ref(&nullable_array));
- });
c.bench_function(&format!("{name}: multiple, no nulls"), |b| {
let arrays = vec![array.clone(), array.clone(), array.clone()];
do_hash_test(b, &arrays);
});
- c.bench_function(&format!("{name}: multiple, nulls"), |b| {
- let arrays = vec![
- nullable_array.clone(),
- nullable_array.clone(),
- nullable_array.clone(),
- ];
- do_hash_test(b, &arrays);
- });
+
+ // Union arrays can't have null bitmasks
Review Comment:
I've copied that from the other PR verbatim 😅 (to not have merge conflicts
in the future?). but I'm getting a sense that it's the wrong approach here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
