notashes commented on code in PR #20182:
URL: https://github.com/apache/datafusion/pull/20182#discussion_r2778163891
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -68,11 +71,25 @@ fn criterion_benchmark(c: &mut Criterion) {
name: "dictionary_utf8_int32",
array: pool.dictionary_array::<Int32Type>(BATCH_SIZE),
},
+ BenchData {
+ name: "struct_array",
+ array: create_struct_array(BATCH_SIZE),
+ },
+ BenchData {
+ name: "run_array_int32",
+ array: create_run_array::<Int32Type>(BATCH_SIZE),
+ },
];
for BenchData { name, array } in cases {
// with_hash has different code paths for single vs multiple arrays
and nulls vs no nulls
- let nullable_array = add_nulls(&array);
+ // RunArray encodes nulls in the values array, not at the array level
+ let nullable_array = if name.starts_with("run_array") {
Review Comment:
Hey @Jefffrey thanks for the reviews! I've followed the pattern from the
other PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
