On Fri, Sep 13, 2019 at 4:32 PM Pratyush Yadav <m...@yadavpratyush.com> wrote: > > On 13/09/19 12:24PM, Allan Ford wrote: > > Dear Git Authors, > > > > Not a bug, but a suggestion consideration for “Git Gui” > > > > Can a double click on the file name in the “unstaged” area move the > > item to “staged changes” .. (rather than having to click on the small > > icon to the left of the file name?) > > It has been something on my radar for some time. Shouldn't be something > too difficult to do. > > While I like the idea in general, I have a question that I'd like to ask > other git-gui users:
I miss a general problem description: Whats wrong with the single-click on the icon to begin with? I consider adding a second way as not not acceptable. I also consider double-click on a file in a GUI an "open" action. But in git-gui, this "open" action (showing the diff) is already done with a single-click. >From my point of view, it can stay as is. Best, Bert > > If we implement something like this, what happens when you single-click > on the icon? Do we treat that as a stage/unstage command? If we keep the > legacy behaviour of single-click on the icon stages/unstages, then a > part of the row is single-click and the rest double-click. > > If we make an entire row of the stage/unstage widget double click, it > messes with people who are already used to it. > > Is partial single and partial double click behaviour acceptable? Or > should we make the entire row double click only? Or something else that > I missed? > > -- > Regards, > Pratyush Yadav
